Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shell-ctx plugin #3326

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Add shell-ctx plugin #3326

merged 3 commits into from
Aug 25, 2023

Conversation

glemsom
Copy link
Contributor

@glemsom glemsom commented Aug 24, 2023

Simple plugin to enable each shell-instance to operate in its own isolated Kubernetex context

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 24, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@ahmetb
Copy link
Member

ahmetb commented Aug 24, 2023

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖

Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot k8s-ci-robot added kind/new-plugin cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 24, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 24, 2023
ahmetb
ahmetb reviewed Aug 25, 2023
View reviewed changes
plugins/shell-ctx.yaml Outdated
spec:
version: "v1.0.2"
homepage: https://github.com/glemsom/shell-ctx
shortDescription: "Kubernetes shell isolated context switcher"
Copy link
Member

@ahmetb ahmetb Aug 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be a higher signal:

Launch isolated shells for contexts

what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the point of the current shortDescription being slightly misleading.
But shell-ctx does actually not spawn a new shell.

What about:

Shell independent context switching

Will that be better ?

Clarification;
The basic idea behind shell-ctx is to hook into the users current shell-instance - allowing the user to keep the same current shell-history, and any other shell-specific settings the user might have.
This will enable Kubernetes administrators to have multible shell windows open, and switch Kubernetes context per shell instance - without risking overwriting currentContext of any other shell instances.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah makes sense.

@glemsom
Copy link
Contributor Author

glemsom commented Aug 25, 2023

Updated pull request with a better shortDescription ed54570

@ahmetb
Copy link
Member

ahmetb commented Aug 25, 2023

/lgtm
/approve
Thanks!
Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, glemsom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit a3e97f7 into kubernetes-sigs:master Aug 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb ahmetb left review comments

@chriskim06 chriskim06 Awaiting requested review from chriskim06

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

Assignees

@ahmetb ahmetb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glemsom @ahmetb @k8s-ci-robot